8000 NAS-134619 / 25.10 / App page uses both "update" and "upgrade" as terminology … by undsoft · Pull Request #12137 · truenas/webui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NAS-134619 / 25.10 / App page uses both "update" and "upgrade" as terminology … #12137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2025
Merged

NAS-134619 / 25.10 / App page uses both "update" and "upgrade" as terminology … #12137

merged 4 commits into from
Jun 16, 2025

Conversation

undsoft
Copy link
Collaborator
@undsoft undsoft commented Jun 15, 2025

Changes:

Upgrade is still used by middleware and so I didn't rename interfaces that refer to middleware objects.
But I think Update sounds better for the UI, so UI-related things were updated.

Downstream

Affects Reasoning
Documentation Minor label and test tag changes.

@undsoft undsoft requested a review from a team as a code owner June 15, 2025 08:47
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team June 15, 2025 08:47
@bugclerk bugclerk changed the title NAS-134619: App page uses both "update" and "upgrade" as terminology … NAS-134619 / 25.10 / App page uses both "update" and "upgrade" as terminology … Jun 15, 2025
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-134619

@undsoft
Copy link
Collaborator Author
undsoft commented Jun 15, 2025

time 0:30

@codecov Codecov
Copy link
codecov bot commented Jun 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.37%. Comparing base (bc862db) to head (5eb1487).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ponents/installed-apps/installed-apps.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #12137   +/-   ##
=======================================
  Coverage   84.37%   84.37%           
=======================================
  Files        1739     1739           
  Lines       61643    61643           
  Branches     6846     6846           
=======================================
  Hits        52009    52009           
  Misses       9634     9634

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AlexKarpov98
AlexKarpov98 approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor
@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@undsoft
Merge branch 'master' of github.com:truenas/webui into NAS-134619
38af1f0 
# Conflicts:
#	src/assets/i18n/ko.json
#	src/assets/i18n/ru.json
@undsoft undsoft enabled auto-merge (squash) June 16, 2025 13:50
undsoft added 2 commits June 16, 2025 16:54
@undsoft
Merge branch 'master' of github.com:truenas/webui into NAS-134619
9a88f1a 
# Conflicts:
#	src/assets/i18n/it.json
#	src/assets/i18n/ko.json
#	src/assets/i18n/ru.json
#	src/assets/i18n/zh-hans.json
@undsoft
Merge branch 'master' of github.com:truenas/webui into NAS-134619
5eb1487 
# Conflicts:
#	src/app/pages/apps/components/installed-apps/installed-apps.component.ts
@undsoft undsoft merged commit 1c0d2ae into master Jun 16, 2025
12 checks passed
@undsoft undsoft deleted the NAS-134619 branch June 16, 2025 16:04
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jun 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexKarpov98 AlexKarpov98 AlexKarpov98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@undsoft @bugclerk @AlexKarpov98
0