capsules: kv: Support 512 byte KV values #4248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the new LoRaWAN examples are writing more then 256 bytes, so let's up the buffer size to allow larger payloads. Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
|
I don't mind this change, though I'm not stoked about the arbitrary nature of the sizes. What about the next application that needs more than 512 bytes? |
alevy
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Some of the new LoRaWAN examples are writing more then 256 bytes, so let's up the buffer size to allow larger payloads.
Testing Strategy
Writing larger K/V values
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.