ot/earlgrey-cw310: custom build.rs that supports alternative linker script for tests #4190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd2692f to
9b93fb6
Compare
lschuermann
previously approved these changes
Oct 7, 2024
bradjc
previously approved these changes
Oct 7, 2024
| mod default; | ||
| pub mod default; |
There was a problem hiding this comment.
Do we want to expose this? We could namespace new functionality in the future, but what we have seems like the normal APIs we can just expose directly.
There was a problem hiding this comment.
Up to you -- I am fine to re-export all of the functions inside default, but it seems easier to just have default be pub and then we can still hide functions inside the file by making individual functions not pub
alistair23
approved these changes
Oct 8, 2024
This commit fixes the hack where OT currently relies on overwriting the linker script in the target directory, instead using a custom build.rs to allow this board to override the linker script in use based on the value of an environment variable. This PR also includes some cleanup to remove some lines that I believe are no longer necessary in the current build system. These line were scattered around the "test" rule for various boards and would directly copy files into the build directory, but I that is already handled by Cargo today.
45568c7 to
db4ee1d
Compare
bradjc
approved these changes
Oct 9, 2024
ppannuto
approved these changes
Oct 9, 2024
|
@pqcfox (or other OT folk), does OT have any issues with this [hopefully it makes things easier long-run]? |
pqcfox
approved these changes
Oct 9, 2024
|
No issues with this at all--very much appreciate these changes going in, this will be really nice to have :) (thanks for pinging me on this!) |
|
Approved by core team and major stakeholders, merging. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request fixes the hack where OT currently relies on overwriting the linker script in the target directory, instead using a custom build.rs to allow this board to override the linker script in use based on the value of an environment variable. Rather than copy much of the existing default build.rs, I refactored it into a few standalone functions that I believe best represent its core functionality. This allowed me to reuse most of those functions in this script, to make it less likely that changes to one fail to propagate to the other.
This PR also includes some cleanup to remove some lines that I believe are no longer necessary in the current build system. These line were scattered around the "test" rule for various boards as a holdover from when those tests would directly copy files into the build directory, which is no longer done.
This PR will unblock #4150.
Testing Strategy
This pull request was tested by compiling + running the tests + looking at the output of
cargo build -vv.TODO or Help Wanted
N/A.
Documentation Updated
Formatting
make prepush.