treadmill-ci: do not run on forks and PRs from other repositories #4187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull requests from forks will not have access to the required GitHub API secrets for the Treadmill CI, even if they are using an appropriate GitHub deployment environment and the workflow runs have been approved according to this environment's rules. We don't know whether this is a bug on GitHub's end or deliberate. Either way, for now we disable this workflow to run on PRs until we have an API proxy that securely performs these GitHub API calls (adding runners and starting Treadmill jobs with those runner registration tokens), which allows this workflow to run without access to repository secrets. For forks themselves, there is no point in running this workflow -- they won't have any Treadmill API tokens configured in their repository secrets by default.
1 task
Samir-Rashid
approved these changes
Oct 1, 2024
ppannuto
approved these changes
Oct 1, 2024
brghena
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This (temporarily) disables the treadmill-ci from running on pull requests and in forks of the Tock repository.
Pull requests from forks will not have access to the required GitHub API secrets for the Treadmill CI, even if they are using an appropriate GitHub deployment environment and the workflow runs have been approved according to this environment's rules.
We don't know whether this is a bug on GitHub's end or deliberate. Either way, for now we disable this workflow to run on PRs until we have an API proxy that securely performs these GitHub API calls (adding runners and starting Treadmill jobs with those runner registration tokens), which allows this workflow to run without access to repository secrets.
For forks themselves, there is no point in running this workflow -- they won't have any Treadmill API tokens configured in their repository secrets by default.
Testing Strategy
This pull request is tested by this PR.
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.