clippy: Document or fix all style lints #4477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was hiding a copy-paste mistake in analog_sensor.rs
Don't create an additional closure when we are just passing a function to map().
Use `if let` consistently.
This helps avoid an extra `mut`.
|
I recently tried disallowing |
lschuermann
approved these changes
Jun 21, 2025
Comment on lines
-85
to
+87
| sensor_type: AnalogLightSensorType, | ||
| ) -> AnalogLightSensor<'a, A> { | ||
| AnalogLightSensor { | ||
| sensor_type: AnalogTemperatureSensorType, | ||
| ) -> Self { | ||
| Self { |
There was a problem hiding this comment.
This seems like it fixes a bug(?) where sensor_type had an incorrect type? Should probably be its own PR.
There was a problem hiding this comment.
Actually even worse, we're constructing a completely wrong type here. Should definitely be its own PR.
That is a pedantic lint, not style |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
I documented all of the clippy lints I think we want to continue allowing with why we allow them.
Many others I removed and fixed the changes.
There are three left over:
declare-interior-mutable-const: fixed in clippy: deny declare-interior-mutable-const #4476missing_safety_doc: needs to be fixed, but is a much bigger jobdoc_lazy_continuation: should be fixed, but will be a big diff and more workTesting Strategy
n/a
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.