8000 Netlify cache fixes by ppannuto · Pull Request #4457 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Netlify cache fixes #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025
Merged

Netlify cache fixes #4457

merged 3 commits into from
Jun 10, 2025

Conversation

ppannuto
Copy link
Member
@ppannuto ppannuto commented Jun 4, 2025

Pull Request Overview

This pull request fixes the netlify build. Netlify now automatically caches all the build artifacts we were manually cacheing before. Our efforts to cache were conflicting with their built-in ones, so we can just delete ours and use the upstream cacheing now.

Testing Strategy

This pull request was tested by iterating with CI.

TODO or Help Wanted

N/A.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@ppannuto ppannuto force-pushed the netlify-cache-fixes branch from 2c2de16 to ac42f1d Compare June 10, 2025 18:40
@ppannuto ppannuto marked this pull request as ready for review June 10, 2025 18:47
@ppannuto ppannuto changed the title WIP: Netlify cache fixes ]Netlify cache fixes Jun 10, 2025
@ppannuto ppannuto changed the title ]Netlify cache fixes Netlify cache fixes Jun 10, 2025
@lschuermann
Copy link
Member

@ppannuto I think you can merge at will, this seems very uncontroversial and you know best about the Netlify magic.

@lschuermann lschuermann added last-call Final review period for a pull request. P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. labels Jun 10, 2025
@ppannuto ppannuto added this pull request to the merge queue Jun 10, 2025
Merged via the queue into master with commit 12a7407 Jun 10, 2025
21 checks passed
@ppannuto ppannuto deleted the netlify-cache-fixes branch June 10, 2025 20:41
@lschuermann
Copy link
Member

Wohoo, it deployed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
last-call Final review period for a pull request. P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0