8000 make: point users to update toolchain file by ppannuto · Pull Request #4444 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

make: point users to update toolchain file #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

make: point users to update toolchain file #4444

merged 1 commit into from
May 23, 2025

Conversation

ppannuto
Copy link
Member

Pull Request Overview

With the more modern tooling, we don't need make to run rustup manually any more, so long as the toolchain file is updated. For folks adding new arches, this updates the default behavior to point them in the right direction instead of quietly papering over the missing toolchain entry.

Testing Strategy

This pull request was tested by compiling.

TODO or Help Wanted

N/A

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@ppannuto
make: point users to update toolchain file
b9ba589 
With the more modern tooling, we don't need `make` to run rustup
manually any more, so long as the toolchain file is updated. For
folks adding new arches, this updates the default behavior to
point them in the right direction instead of quietly papering over
the missing toolchain entry.
@bradjc bradjc added this pull request to the merge queue May 23, 2025
Merged via the queue into master with commit 93ef350 May 23, 2025
17 of 21 checks passed
@bradjc bradjc deleted the dont-run-rustup-anymore branch May 23, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brghena brghena brghena approved these changes

@bradjc bradjc bradjc approved these changes

Assignees

@bradjc bradjc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
< 3517 div class="participation-avatars d-flex flex-wrap"> @ppannuto @brghena @bradjc
0