Fix abort upcall bug #4423
Merged
Fix abort upcall bug #4423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lschuermann
reviewed
May 6, 2025
| @@ -504,7 +504,6 @@ impl< | |||
| match result { | |||
| Ok(()) => { | |||
| self.new_app_length.set(0); | |||
| self.current_process.take(); | |||
There was a problem hiding this comment.
For anyone reasoning about why this is correct, the code above this match block always ensures that self.current_process is set to the calling process. Furthermore, abort is an asynchronous operation. Thus, this will need to leave the current_process set until the abort operation has finished.
There was a problem hiding this comment.
Yes, sorry for not including that. Thanks Leon!
lschuermann
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Because of an extraneous
self.process.take()in the synchronous response to theabortcall, the capsule was unable to send the asynchronous upcall on a successful/unsuccessful abort operation. This PR fixes this issue.Testing Strategy
I tested both versions of the kernel on my nrf52840dk.
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.