Remove the last .c file: tools/bulk-echo-fast #4412
Conversation
This is in C, and our only C code.
There was a problem hiding this comment.
:/, is this test no longer useful? It seems like the code is all still valid...
Should it at least move to tock-archive? Or some tock-tools / tock-support / etc style repo?
Or maybe @alevy has opinions and tools on how to just automagically convert this C code to Rust? :)
|
I imagine the test still works, but we have a lot more USB code and end-to-end uses than we did when this was added. |
|
This should not be hard to re-write in Rust, fwiw. I do agree that it's not a very robust test relative to the amount of USB we actually have now. @charles37 will be working on USB tests on treadmill soon, which would likely supercede this anyway. Not sure when the last time someone ran this was... |
|
Looking in that directory and at this history for a second, there already is a
Now, it's likely (especially with modern async) that the world has improved in Rust cross-platform USB since 2018, but it seems like we should do the work of porting the test to Rust (to prove that it can actually be done) before just deleting it :/ |
|
I think porting it to |
|
Yeah I guess so, but no one is going to bother to port this test no one uses. |
|
I think basically @charles37 maybe should port it (as part of the Treadmill testing). As far as I'm concerned we can remove it for now I guess, since we can just look in the git history for it as a reference. |
Pull Request Overview
This is in C, and our only C code.
This is really just for vanity.
Testing Strategy
n/a
TODO or Help Wanted
Move to tock-archive?
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.