Add the required . at the end of copyright lines.
#3379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I implemented the license checker in tock#3345, I did not notice that `trd-legal.md` required a period (`.`) at the end of the copyright line. This PR adds that period to the license headers from tock#3345. This begs the question: should I add logic to the license checker than checks the format of `Copyright` lines? I'm leaning towards "no" because they *should* be mostly copy-and-paste and it minor punctuation errors don't seem very significant.
hudson-ayers
approved these changes
Jan 20, 2023
|
Re: your question, I also lean towards "no" |
twilfredo
approved these changes
Jan 23, 2023
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
When I implemented the license checker in #3345, I did not notice that
trd-legal.mdrequires a period at the end of the copyright line. This PR adds that period to the license headers from #3345.This begs the question: should I add logic to the license checker than checks the format of
Copyrightlines? I'm leaning towards "no" because they should be mostly copy-and-paste and minor punctuation errors don't seem very significant.Documentation Updated
/docs, or no updates are required.Formatting
make prepush.