8000 Re-add OpenTitan's VFUNC_ELIM flag by jwnrt · Pull Request #3374 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Re-add OpenTitan's VFUNC_ELIM flag #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

Re-add OpenTitan's VFUNC_ELIM flag #3374

merged 1 commit into from
Jan 11, 2023

Conversation

jwnrt
Copy link
Contributor
@jwnrt jwnrt commented Jan 11, 2023

Pull Request Overview

This PR re-adds the VFUNC_ELIM=1 flag back to OpenTitan's makefile.

The flag was deleted by #3359 presumably by mistake when fixing a conflict.

Testing Strategy

Ran make test with the flag set.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

8000
@jwnrt
Re-add OpenTitan's VFUNC_ELIM flag
c0a2131 
Seems to have been deleted by mistake when fixing conflicts for
tock#3359.
@github-actions github-actions bot added the WG-OpenTitan In the purview of the OpenTitan working group. label Jan 11, 2023
hudson-ayers
hudson-ayers approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor
@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, good catch. Github really needs a better UI for showing changes after a rebase/force-push.

@hudson-ayers hudson-ayers added the P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. label Jan 11, 2023
@hudson-ayers
Copy link
Contributor

bors r+

@bors
Copy link
Contributor
bors bot commented Jan 11, 2023

Build succeeded:

@bors bors bot merged commit 8655505 into tock:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair23 alistair23 alistair23 approved these changes

@jrvanwhy jrvanwhy jrvanwhy approved these changes

@hudson-ayers hudson-ayers hudson-ayers approved these changes

Assignees
No one assigned
Labels
P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jwnrt @hudson-ayers @alistair23 @jrvanwhy
0