USB implementation for Raspberry Pi Pico #3310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandruradovici
requested changes
Nov 2, 2022
twilfredo
suggested changes
Nov 3, 2022
|
Any feedback on the USB implementation would be very much appreciated. If this looks good from the USB side, merging this quickly would allow educators to use the Raspberry Pi with Tock, as it does not have a hardware serial to USB line. |
hudson-ayers
previously approved these changes
Nov 11, 2022
twilfredo
reviewed
Nov 12, 2022
twilfredo
reviewed
Nov 12, 2022
twilfredo
reviewed
Nov 12, 2022
twilfredo
previously approved these changes
Nov 12, 2022
bradjc
reviewed
Nov 15, 2022
d96aec0
alexandruradovici
requested changes
Dec 1, 2022
Co-authored-by: Alexandru Radovici <msg4alex@gmail.com>
|
I updated the makefile so that the kernel can also be flashed to the pico via bootsel. Is there anything else that needs changing? |
hudson-ayers
approved these changes
Dec 7, 2022
|
Is there anything that we have to do for the PR? I would help us if we could merge this as we can use the Raspberry Pi easier. |
bradjc
approved these changes
Dec 16, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds USB functionality for the Raspberry Pi Pico board. It was implemented together with @cosmindanielradu19 and was inspired by the USB implementation for the nrf52 board. This PR allows write (IN) transfers over USB for the Raspberry Pi Pico (which means that users are able to see output messages over the console) and read (OUT) transfers (users can send input to the board through the console). Panics are still written to UART.
Testing Strategy
This pull request was tested using a Raspberry Pi Pico.
TODO or Help Wanted
This pull request still needs feedback as this was heavily inspired from nrf52.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.