8000 boards/opentitan: App loading for Verilator by twilfredo · Pull Request #3269 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

boards/opentitan: App loading for Verilator #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2022
Merged

boards/opentitan: App loading for Verilator #3269

merged 2 commits into from
Oct 7, 2022

Conversation

twilfredo
Copy link
Contributor

Pull Request Overview

  • Adds a way to bundle a single app with the kernel for Verilator.

  • Update OpenTitan paths to match the artifact locations created by the commands in README.

Usage (example loading OTBN binary):

$ APP=$OPENTITAN_TREE/bazel-out/k8-fastbuild-ST-2cc462681f62/bin/sw/otbn/crypto/rsa.tbf make BOARD_CONFIGURATION=sim_verilator verilator

Or for when testing:

$ APP=$OPENTITAN_TREE/bazel-out/k8-fastbuild-ST-2cc462681f62/bin/sw/otbn/crypto/rsa.tbf make BOARD_CONFIGURATION=sim_verilator test-verilator

Testing Strategy

By loading the OTBN Binary and checking that Tock detects it at board init.

TODO or Help Wanted

Although, we can get the OTBN loaded and detected (in both test/non-test cases), I was unable to get a libtock-c app to run. Testing with c-hello produced no output after Tock loaded (after OpenTitan initialisation complete. Entering main loop). Any ideas ?

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@twilfredo
boards/opentitan: App support for Verilator
cd2f410 
Adds a way to bundle and app with the kernel for when using Verilator.

Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
@github-actions github-actions bot added the WG-OpenTitan In the purview of the OpenTitan working group. label Oct 6, 2022
twilfredo
twilfredo commented Oct 6, 2022
View reviewed changes
@twilfredo
boards/opentitan/README: Update docs for Verilator
5122d28 
Add Verilator instructions for loading app/otbn

Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
@phil-levis
Copy link
Contributor

bors r+

@bors
Copy link
Contributor
bors bot commented Oct 7, 2022

Build succeeded:

@bors bors bot merged commit 3e70e92 into tock:master Oct 7, 2022
@twilfredo twilfredo deleted the add_verilator_apps branch November 13, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair23 alistair23 alistair23 approved these changes

@bradjc bradjc bradjc approved these changes

Assignees
No one assigned
Labels
WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twilfredo @phil-levis @alistair23 @bradjc
0