components: fxo: update to new _static #3237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudson-ayers
previously approved these changes
Sep 21, 2022
391932c to
4826dca
Compare
move buffer to component remove imix component update hail to use component
4826dca to
c6bdca8
Compare
alistair23
approved these changes
Sep 27, 2022
twilfredo
reviewed
Sep 28, 2022
| let fxo = kernel::static_buf!(capsules::fxos8700cq::Fxos8700cq<'static>); | ||
|
|
||
| (i2c_device, buffer, fxo) | ||
| };}; |
There was a problem hiding this comment.
Suggested change
| };}; | |
| }}; |
Does this not generate a warning here? Similar to in #3245
There was a problem hiding this comment.
I'm confused what is causing the warning, or not causing the warning in the case of capsules. I've seen other PRs that add the semicolon to fix something, so I'm not really sure what the right thing to do is.
There was a problem hiding this comment.
I thought it might be for when the macro returns something, like in this case and in #3245 . But if there's no warnings I'm not sure either...🤔
hudson-ayers
approved these changes
Oct 4, 2022
ppannuto
approved these changes
Oct 7, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request updates the fxo accelerometer component to use new static format.
Also:
Testing Strategy
travis
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.