8000 Component: Update bmX280 components by bradjc · Pull Request #3232 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Component: Update bmX280 components #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2022
Merged

Component: Update bmX280 components #3232

merged 2 commits into from
Oct 7, 2022

Conversation

bradjc
Copy link
Contributor
@bradjc bradjc commented Sep 20, 2022

Pull Request Overview

Update these components to use _static macro, static_buf, and use new() for all configuration.

Testing Strategy

travis

TODO or Help Wanted

Any thoughts on components using other components? bmp280 was using the I2C component, but it's hard to update all components at once, so I just replicated the i2c init because it is pretty simple.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

hudson-ayers
hudson-ayers previously approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor
@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: components using other components, I think we want to avoid that, unless the call to the helper!()/static!() macro for the other component is contained within the macro for the outer component. Otherwise, the component is still not reusable

@bradjc bradjc added the blocked Waiting on something, like a different PR or a dependency. label Sep 22, 2022
@bradjc bradjc force-pushed the component-bm280 branch 2 times, most recently from b776a9c to 2bcfbdd Compare September 26, 2022 17:16
@bradjc bradjc changed the title Component: Updater bmX280 components Component: Update bmX280 components Sep 26, 2022
@bradjc bradjc removed the blocked Waiting on something, like a different PR or a dependency. label Sep 26, 2022
@github-actions github-actions bot removed the kernel label Sep 26, 2022
alistair23
alistair23 previously approved these changes Sep 26, 2022
View reviewed changes
phil-levis
phil-levis previously approved these changes Oct 3, 2022
View reviewed changes
alistair23
alistair23 previously approved these changes Oct 4, 2022
View reviewed changes
hudson-ayers
hudson-ayers previously approved these changes Oct 4, 2022
View reviewed changes
ppannuto
ppannuto previously approved these changes Oct 7, 2022
View reviewed changes
@ppannuto ppannuto added last-call Final review period for a pull request. needs-rebase labels Oct 7, 2022
@ppannuto
Copy link
Member
ppannuto commented Oct 7, 2022

bors r+

looks good; and just waiting on mac build which should finish by the time bors gets to it

@bors
Copy link
Contributor
bors bot commented Oct 7, 2022

Build succeeded:

@bors bors bot merged commit 09600e9 into master Oct 7, 2022
@bors bors b 83EF ot deleted the component-bm280 branch October 7, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppannuto ppannuto ppannuto approved these changes

@alistair23 alistair23 alistair23 left review comments

@phil-levis phil-levis phil-levis left review comments

@hudson-ayers hudson-ayers hudson-ayers left review comments

Assignees
No one assigned
Labels
component last-call Final review period for a pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bradjc @ppannuto @alistair23 @phil-levis @hudson-ayers
0