8000 Process Console New(ish) Commands by bradjc · Pull Request #3171 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Process Console New(ish) Commands #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Process Console New(ish) Commands #3171

merged 3 commits into from
Sep 8, 2022

Conversation

bradjc
Copy link
Contributor
@bradjc bradjc commented Aug 26, 2022

Pull Request Overview

This adds the terminate and boot commands from the app id PR to process console.

This also restores my panic command which was removed for some reason at some point.

Testing Strategy

Using the process console on hail.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

Copy link
Contributor
@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though until AppId is in it seems like boot basically does nothing, since a process can never be unstarted while the process console is running?

@bradjc
Copy link
Contributor Author
bradjc commented Aug 31, 2022

Looks good, though until AppId is in it seems like boot basically does nothing, since a process can never be unstarted while the process console is running?

Aha, except for using the new terminate command with the process console!

@bradjc
Copy link
Contributor Author
bradjc commented Sep 7, 2022

ping!

I really want the panic command back :)

@phil-levis
Copy link
Contributor

bors r+

@bors
Copy link
Contributor
bors bot commented Sep 8, 2022

@bors bors bot merged commit e4d88bc into master Sep 8, 2022
@bors bors bot deleted the pconsole-updates-cmds branch September 8, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0