Update nightly September October 2022 #3168

bradjc · 2022-08-26T15:48:09Z

Pull Request Overview

Placeholder PR to update the nightly after the release.

We're actually not on too old of a version, but September will be keeping with our approximate two month cadence.

Needed a patch to clippy first, which didn't land until October.

Testing Strategy

travis

TODO or Help Wanted

n/a

Documentation Updated

Updated the relevant files in /docs, or no updates are required.

Formatting

Ran make prepush.

bradjc · 2022-09-07T14:24:33Z

I tried to get a newer nightly, but it appears miri hasn't been available for a couple weeks:

This nightly doesn't work because of:

$ make
   Compiling esp32-c3-board v0.1.0 (/Users/bradjc/git/tock/boards/esp32-c3-devkitM-1)
error: linking with `rust-lld` failed: exit status: 1
  |
  = note: "rust-lld" "-flavor" "gnu" "/var/folders/_4/n3tmwxks3318tsb36d913f600000gn/T/rustcTA0cjJ/symbols.o" "/Users/bradjc/git/tock/target/riscv32imc-unknown-none-elf/release/deps/esp32_c3_board-cc095587c204838f.esp32_c3_board.61e0b048-cgu.0.rcgu.o" "--as-needed" "-L" "/Users/bradjc/git/tock/target/riscv32imc-unknown-none-elf/release/deps" "-L" "/Users/bradjc/git/tock/target/release/deps" "-L" "/Users/bradjc/.rustup/toolchains/nightly-2022-08-26-x86_64-apple-darwin/lib/rustlib/riscv32imc-unknown-none-elf/lib" "-Bstatic" "/Users/bradjc/git/tock/target/riscv32imc-unknown-none-elf/release/deps/libcompiler_builtins-176bfe12cc139d74.rlib" "-Bdynamic" "-znoexecstack" "-L" "/Users/bradjc/.rustup/toolchains/nightly-2022-08-26-x86_64-apple-darwin/lib/rustlib/riscv32imc-unknown-none-elf/lib" "-o" "/Users/bradjc/git/tock/target/riscv32imc-unknown-none-elf/release/deps/esp32_c3_board-cc095587c204838f" "--gc-sections" "-L/Users/bradjc/git/tock/boards/esp32-c3-devkitM-1" "-Tlayout.ld" "-nmagic" "-icf=all"
  = note: rust-lld: warning: section type mismatch for .stack_buffer
          >>> /Users/bradjc/git/tock/target/riscv32imc-unknown-none-elf/release/deps/esp32_c3_board-cc095587c204838f.esp32_c3_board.61e0b048-cgu.0.rcgu.o:(.stack_buffer): SHT_PROGBITS
          >>> output section .stack: SHT_NOBITS

          rust-lld: error: /Users/bradjc/git/tock/target/riscv32imc-unknown-none-elf/release/deps/esp32_c3_board-cc095587c204838f.esp32_c3_board.61e0b048-cgu.0.rcgu.o:(.rodata.cst16): offset is outside the section


error: could not compile `esp32-c3-board` due to previous error

I tried playing around with sizes and linker constants and nothing changed the error. I can't explain why it only seems to affect this board. I didn't see anything unusual about the linker setup for this board.

bradjc · 2022-09-08T13:02:40Z

I tried a newer nightly and this issue went away. So I guess we just wait for miri.

bradjc · 2022-09-12T15:41:02Z

Now the issue is clippy. I tried on today's nightly and get:

    Checking nrf52_components v0.1.0 (/Users/bradjc/git/tock/boards/nordic/nrf52_components)
thread 'rustc' panicked at 'normalization works on validated constants: InterpErrorInfo(InterpErrorInfoInner { kind: using uninitialized data, but this operation requires initialized memory, backtrace: None })', compiler/rustc_const_eval/src/const_eval/eval_queries.rs:138:36
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.1.65 (59e7a308 2022-09-11)

query stack during panic:
#0 [try_destructure_mir_constant] destructuring mir constant
#1 [analysis] running analysis passes on this crate
end of query stack
error: could not compile `qemu_rv32_virt`
warning: build failed, waiting for other jobs to finish...
thread 'rustc' panicked at 'normalization works on validated constants: InterpErrorInfo(InterpErrorInfoInner { kind: using uninitialized data, but this operation requires initialized memory, backtrace: None })', compiler/rustc_const_eval/src/const_eval/eval_queries.rs:138:36
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.1.65 (59e7a308 2022-09-11)

query stack during panic:
#0 [try_destructure_mir_constant] destructuring mir constant
#1 [analysis] running analysis passes on this crate
end of query stack
thread 'rustc' panicked at 'normalization works on validated constants: InterpErrorInfo(InterpErrorInfoInner { kind: using uninitialized data, but this operation requires initialized memory, backtrace: None })', compiler/rustc_const_eval/src/const_eval/eval_queries.rs:138:36
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.1.65 (59e7a308 2022-09-11)

query stack during panic:
#0 [try_destructure_mir_constant] destructuring mir constant
#1 [analysis] running analysis passes on this crate
end of query stack
error: could not compile `redboard_redv`
error: could not compile `hifive1`
thread 'rustc' panicked at 'normalization works on validated constants: InterpErrorInfo(InterpErrorInfoInner { kind: using uninitialized data, but this operation requires initialized memory, backtrace: None })', compiler/rustc_const_eval/src/const_eval/eval_queries.rs:138:36
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.1.65 (59e7a308 2022-09-11)

query stack during panic:
#0 [try_destructure_mir_constant] destructuring mir constant
#1 [analysis] running analysis passes on this crate
end of query stack
error: could not compile `hail`
thread 'rustc' panicked at 'normalization works on validated constants: InterpErrorInfo(InterpErrorInfoInner { kind: using uninitialized data, but this operation requires initialized memory, backtrace: None })', compiler/rustc_const_eval/src/const_eval/eval_queries.rs:138:36
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.1.65 (59e7a308 2022-09-11)

query stack during panic:
#0 [try_destructure_mir_constant] destructuring mir constant
#1 [analysis] running analysis passes on this crate
end of query stack
thread 'rustc' panicked at 'normalization works on validated constants: InterpErrorInfo(InterpErrorInfoInner { kind: using uninitialized data, but this operation requires initialized memory, backtrace: None })', compiler/rustc_const_eval/src/const_eval/eval_queries.rs:138:36
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.1.65 (59e7a308 2022-09-11)

query stack during panic:
#0 [try_destructure_mir_constant] destructuring mir constant
#1 [analysis] running analysis passes on this crate
end of query stack
error: could not compile `msp-exp432p401r`
error: could not compile `stm32f412`

hudson-ayers · 2022-09-12T19:21:52Z

The root of the ICE is the constant we create on this line:

tock/boards/components/src/sched/round_robin.rs

Line 27 in 2685c14

    
           const UNINIT: MaybeUninit<RoundRobinProcessNode<'static>> = MaybeUninit::uninit();

. I posted an MCVE to the clippy and rust repositories so hopefully a compiler dev will be able to quickly fix this bug, but if not we could probably get around it by making this initialization macro more complex (read: recursive) instead of using the use a "constant to get around the array initialization shortcomings" trick.

bradjc · 2022-09-12T20:25:17Z

we could probably get around it by making this initialization macro more complex (read: recursive) instead of using the use a "constant to get around the array initialization shortcomings" trick.

Luckily we are in no hurry, our last update was in July so we are right on schedule. But, this is exactly why we update the nightly every two months.

bradjc · 2022-09-23T14:15:34Z

I'm a little concerned about our ability to update rust at this point.

bradjc · 2022-09-28T17:56:07Z

I tried the latest nightly, but it doesn't seem the fix is included yet.

bradjc · 2022-10-04T04:16:03Z

I think we are waiting on clippy changes to be upstreamed, which will hopefully happen in the next week.

bradjc · 2022-10-04T15:00:40Z

https://github.com/rust-lang/rust/pulls?q=is%3Apr+%22Update+Clippy%22+

bradjc · 2022-10-09T02:29:28Z

Ok this should finally be ready!

hudson-ayers · 2022-10-12T19:48:11Z

bors r+

bors · 2022-10-12T20:21:30Z

Build succeeded:

github-actions bot added the stm32 Change pertains to the stm32 family of MCUSs label Aug 26, 2022

alistair23 previously approved these changes Aug 29, 2022

View reviewed changes

bradjc dismissed alistair23’s stale review via 2a2c412 September 8, 2022 14:21

bradjc force-pushed the update-nightly-sep-2022 branch from fb65163 to 2a2c412 Compare September 8, 2022 14:21

bradjc mentioned this pull request Sep 8, 2022

ICE: thread 'rustc' panicked at 'normalization works on validated constants...' rust-lang/rust-clippy#9445

Closed

bradjc added the blocked-upstream Waiting on something from an upstream project label Sep 23, 2022

bradjc force-pushed the update-nightly-sep-2022 branch from 2a2c412 to 2e4e5e5 Compare September 28, 2022 17:55

github-actions bot added the WG-OpenTitan In the purview of the OpenTitan working group. label Sep 28, 2022

bradjc force-pushed the update-nightly-sep-2022 branch from 2e4e5e5 to a821b7a Compare October 7, 2022 13:43

bradjc added 3 commits October 8, 2022 22:26

update nightly oct 2022

bc17e7e

remove () warnings with new nightly

bbcde32

chips: lowrisc: remove modify loop var in loop

f11036d

bradjc force-pushed the update-nightly-sep-2022 branch from a821b7a to f11036d Compare October 9, 2022 02:28

bradjc removed the blocked-upstream Waiting on something from an upstream project label Oct 9, 2022

bradjc changed the title ~~Update nightly September 2022~~ Update nightly ~~September~~ October 2022 Oct 9, 2022

alistair23 approved these changes Oct 9, 2022

View reviewed changes

hudson-ayers approved these changes Oct 10, 2022

View reviewed changes

bors bot merged commit 64f39db into master Oct 12, 2022

bors bot deleted the update-nightly-sep-2022 branch October 12, 2022 20:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update nightly September October 2022 #3168

Update nightly September October 2022 #3168

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Update nightly ~~September~~ October 2022 #3168

Update nightly ~~September~~ October 2022 #3168

Uh oh!

Conversation

Uh oh!

Pull Request Overview

Testing Strategy

TODO or Help Wanted

Documentation Updated

Formatting

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Update nightly September October 2022 #3168

Update nightly September October 2022 #3168