cortex-m: cleanup linker constants #3150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudson-ayers
requested changes
Aug 18, 2022
There was a problem hiding this comment.
I think we should also apply these changes to here:
tock/boards/opentitan/src/main.rs
Line 661 in 915863e
These were the wrong type (they're all pointers..) and should not have been `mut`.
2454555 to
53d0db4
Compare
I think this comment still applies |
|
Yep, I false-started on cleaning that up and finishing this the other day; will roll this over from draft to ready when it's actually ready. |
|
Can we merge this? |
brghena
approved these changes
Oct 9, 2023
alistair23
approved these changes
Oct 10, 2023
hudson-ayers
approved these changes
Nov 19, 2023
8000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This is the follow-on to #3147 that does the real fix here. I still think #3147 should go in for 2.1 as a quick-fix, and then this can come in after as the better fix.
This fixes the type imports from the linker script to match reality (they're const pointers). I think this was just some real legacy stuff that predated our understanding of Rust.
Testing Strategy
Todo: will test on HW when I'm in the office next week.
TODO or Help Wanted
^see above
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.