8000 boards: stm32: use std openocd config by bradjc · Pull Request #3926 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

boards: stm32: use std openocd config #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2024
Merged

boards: stm32: use std openocd config #3926

merged 1 commit into from
Mar 22, 2024

Conversation

bradjc
Copy link
Contributor
@bradjc bradjc commented Mar 21, 2024 •
edited
Loading

Pull Request Overview

Use the standard openocd config for STM boards. I've run into issues with openocd and the stm32f429zi board. It's possible this is an improvement. It's probably better to just use the built in boards in openocd so we have fewer files to maintain.

I didn't include the changes to the board that I do have in this PR.

Testing Strategy

Nothing, unfortunately. I don't have these boards. But I'm worried about bitrot with these boards.

TODO or Help Wanted

Thoughts?

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

alevy
alevy approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member
@alevy alevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly support this. It's very likely that openocd didn't have built in support for these boards originally, but does now. If this breaks something, we can always bring this back.

alevy
alevy requested changes Mar 21, 2024
View reviewed changes
Copy link
Member
@alevy alevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License headers

alevy
alevy reviewed Mar 21, 2024
View reviewed changes
@bradjc
Copy link
Contributor Author
bradjc commented Mar 21, 2024

I don't understand what's happening with the license headers.

@alevy
Copy link
Member
alevy commented Mar 21, 2024

I don't understand what's happening with the license headers.

There were some strange diffs going on, and ultimately I don't think the license headers were the problem (but rather an incorrectly removed Makefile variable). But the license headers don't hurt...

@alevy
Copy link
Member
alevy commented Mar 21, 2024

Oh, I see... I was wrong. Will fix

@github-actions github-actions bot added kernel WG-OpenTitan In the purview of the OpenTitan working group. component labels Mar 21, 2024
@github-actions github-actions bot removed kernel WG-OpenTitan In the purview of the OpenTitan working group. component labels Mar 21, 2024
@alevy alevy force-pushed the stm32-openocd branch 2 times, most recently from 6a585e5 to 8f1a214 Compare March 21, 2024 13:37
@alevy alevy enabled auto-merge March 22, 2024 03:27
@alevy alevy added this pull request to the merge queue Mar 22, 2024
Merged via the queue into master with commit eafa96c Mar 22, 2024
@alevy alevy deleted the stm32-openocd branch March 22, 2024 04:03
@bradjc bradjc mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alevy alevy alevy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradjc @alevy
0