Raw Receive #3919
Merged
Raw Receive #3919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-passes encrypted packets to userland rather than dropping when 15.4 capsule does not possess the relevant networkkey
26 tasks
alevy
approved these changes
Mar 15, 2024
brghena
approved these changes
Mar 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request addresses the challenge addressed in #3903. This implementation elects to naively pass the encrypted packet to userland. The primary drawback of this implementation is that encrypted and decrypted packets are passed to userland in the same manner and the userprocess must infer if the packet remains encrypted. In actuality, this is less of a concern as the userprocess may assume the packet is decrypted if it registered a network key and encrypted if it did not register a key with the 15.4 capsule.
Testing Strategy
This pull request was tested as part of the OpenThread port.
TODO or Help Wanted
This pull request needs comments on the design choice to naively pass packets. The alternative is to add additional metadata to the passed packet (as proposed in the #3903).
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.