8000 Resolve "unused import: `core::arch::global_asm`" warnings. by jrvanwhy · Pull Request #3887 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Resolve "unused import: core::arch::global_asm" warnings. #3887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

Resolve "unused import: core::arch::global_asm" warnings. #3887

merged 1 commit into from
Feb 27, 2024

Conversation

jrvanwhy
Copy link
Contributor

A few of the board main files have global_asm! statements that are #[cfg(...)]-ed to disappear when built on non-embedded targets. This results in "unused import" warnings when cargo check and cargo clippy are run by make prepush.

Because writing core::arch::global_asm does not noticeably affect readability, I'm just removing the use statements rather than than adding #[allow(unused_imports)].

Resolve "unused import: core::arch::global_asm" warnings.
f8c40da 
A few of the board main files have `global_asm!` statements that are `#[cfg(...)]`-ed to disappear when built on non-embedded targets. This results in "unused import" warnings when `cargo check` and `cargo clippy` are run by `make prepush`.

Because writing `core::arch::global_asm` does not noticeable affect readability, I'm just removing the use statements rather than than adding `#[allow(unused_imports)]`.
@jrvanwhy jrvanwhy requested a review from bradjc February 27, 2024 20:24
bradjc
bradjc approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor
@bradjc bradjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to the list! So many PRs this year to fix this particular cargo problem. re: #3865

@bradjc bradjc added this pull request to the merge queue Feb 27, 2024
Merged via the queue into tock:master with commit 48c102a Feb 27, 2024
@jrvanwhy jrvanwhy deleted the rm-unused-global_asm branch January 31, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradjc bradjc bradjc approved these changes

@lschuermann lschuermann lschuermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrvanwhy @bradjc @lschuermann
0