Tockbot improvements #3886
Merged
Tockbot improvements #3886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Some quick Tockbot improvements around the "stale_pr_assign" tasks:
The last point could be problematic. It might cause blocked PRs to linger for a long time, as we don't have a great way to correlate this "block" with its blocking dependency (internal Tock PR, upstream PR, something entirely different).
One solution could be to collect such PRs that have been blocked for a long time (e.g., a month) for brief manual review, either by assigning a reviewer or putting an item on the core WG call agenda.
Testing Strategy
Running locally in dry-run mode.
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.