HIL: Add Signature::verify with const L:usize and process checker for signatures
#3878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const L:usize and process checker for signatures
alevy
reviewed
Feb 23, 2024
alevy
reviewed
Feb 23, 2024
alevy
reviewed
Feb 23, 2024
alevy
previously approved these changes
Feb 23, 2024
|
As discussed, this PR should not be blocked on whether the digest HIL and digest-related HILs should have the specific algorithm as a type parameter, rather than a const length (which would have other potentially problematic knock on effects). As is, this PR adds useful, long-overdue, functionality and the questions raised originally (now in #3772) are separate IMO. |
alevy
previously approved these changes
Feb 24, 2024
alistair23
previously requested changes
Feb 26, 2024
alevy
approved these changes
Feb 27, 2024
The requested changes have been addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This is an alternative to #3772, and is in fact the original version of that PR.
Testing Strategy
This pull request was tested by...
TODO or Help Wanted
This pull request still needs...
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.