chips/apollo3: A collection of I2C fixes #3840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Previously if a THR (threshold) or CMDCMP (command complete) interrupt occured we handled them both the same way. This works for small amounts of data as we could finish sending all the data before triggering the command complete callback. If trying to send large payloads (128 bytes for example) we actually get a number of THR interrupts before we have completed the write operation. The existing logic would return complete before we had finished the operation. This patch splits the hadling of THR and CMDCMP so we will only return if the hardware provides a CMDCMP interrupt. Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
twilfredo
reviewed
Feb 9, 2024
twilfredo
approved these changes
Feb 10, 2024
bradjc
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This is a collection of fixes discovered while trying to send large (~128 byte) transfers
Testing Strategy
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.