lowrisc: usb: change while to if #3749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This while loop can only ever execute once because there are break statements in all of the valid match arms. This was found via a new clippy lint. This patch makes the code match what is actually happening. I don't know if it should be a loop and the breaks are the issue, however.
alistair23
approved these changes
Nov 23, 2023
twilfredo
approved these changes
Nov 23, 2023
alevy
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This while loop can only ever execute once because there are break statements in all of the valid match arms.
This was found via a new clippy lint.
This patch makes the code match what is actually happening. I don't know if it should be a loop and the breaks are the issue, however.
Testing Strategy
No testing, just travis.
TODO or Help Wanted
Is this the right fix?
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.