8000 Nano33BLE Sense Rev2: Board Implementation by TheButterMineCutter · Pull Request #3717 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Nano33BLE Sense Rev2: Board Implementation #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 4, 2024
Merged

Nano33BLE Sense Rev2: Board Implementation #3717

merged 9 commits into from
Mar 4, 2024

Conversation

TheButterMineCutter
Copy link
Contributor
@TheButterMineCutter TheButterMineCutter commented Oct 20, 2023 •
edited
Loading

Pull Request Overview

This pull request implements the entire board implementation for the Nano33BLE Sense Rev2 board.

Testing Strategy

Nano33BLE Sense Rev2

TODO or Help Wanted

  • Sensor Driver for BMI270

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@TheButterMineCutter TheButterMineCutter marked this pull request as draft October 20, 2023 19:19
@alevy
Copy link
Member
alevy commented Oct 20, 2023

@TheButterMineCutter Awesome!

What is the difference between this implementation and the rev1 implementation?

Is this summary from the Arduino website correct (except this version doesn't yet have the BMI270)?

  • Replacement of IMU from LSM9DS1 (9 axis) for a combination of two IMUs (BMI270 - 6 axis IMU and BMM150 - 3 axis
  • Replacement of temperature and humidity sensor from HTS221 for HS3003.
  • Replacement of microphone from MP34DT05 to MP34DT06JTR.

Is the code otherwise "copy-pasted" from the nano33ble crate?

I'm inclined to go with this, with two hesitations:

  1. It might be nice to rethink the naming, as I expect most new people getting a nano33ble to get the rev2 now
  2. If the above is right, there's a fair amount of redundancy for bugs/misconfigurations to unnecessarily appear, especially since most people working on this won't have both versions.

@alevy alevy mentioned this pull request Oct 20, 2023
Merged
2 tasks
@TheButterMineCutter
Copy link
Contributor Author

The main distinction between this implementation and the rev1 version is the summary sourced from the Arduino website. Apart from that, the entire code has been directly copied from the nano33ble crate. The documentation hasn't been extensively modified, so it may require adjustments to ensure alignment with this implementation. If you have any suggestions for a fitting name, feel free to share your ideas.

bradjc
bradjc reviewed Oct 24, 2023
View reviewed changes
Copy link
< 8000 /div>
Contributor
@bradjc bradjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My take is that components are good enough that we can duplicate boards like this without major ramifications.

Also I'm not in favor of renaming the other board as the marketing for rev2 makes it pretty clear you have a rev2:
image

bradjc
bradjc reviewed Nov 27, 2023
View reviewed changes
bradjc
bradjc previously approved these changes Nov 29, 2023
View reviewed changes
@bradjc
Copy link
Contributor
bradjc commented Jan 18, 2024

I guess this just needs to advance beyond draft form.

@bradjc bradjc marked this pull request as ready for review February 27, 2024 21:22
@brghena brghena mentioned this pull request Feb 29, 2024
Open
2 tasks
@alevy
Copy link
Member
alevy commented Mar 1, 2024

I suggest we merge this without the ninedof driver, which relies on #3719, which is basically blocked on figuring out that peripheral. This board is useful to have also without the driver.

@bradjc
Copy link
Contributor
bradjc commented Mar 1, 2024

I suggest we merge this without the ninedof driver, which relies on #3719, which is basically blocked on figuring out that peripheral. This board is useful to have also without the driver.

Agreed.

alevy
alevy requested changes Mar 2, 2024
View reviewed changes
@bradjc bradjc added this pull request to the merge queue Mar 4, 2024
Merged via the queue into tock:master with commit bc694f8 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alevy alevy alevy approved these changes

@bradjc bradjc bradjc approved these changes

Assignees

@jrvanwhy jrvanwhy

Labels
component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheButterMineCutter @alevy @bradjc @jrvanwhy
0