Refactoring of Earlgrey GPIO driver #3710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
b3928b2 to
6b42a4b
Compare
|
I think a rebase here would help with reviewing now that the register changes are merged. |
This commit add new enum PadConfig used as representation of association between pad and internal chip I/O. This new enum implement GPIO::Configure interface in order to provide necessary functionality for GPIO such as floating state management and low power state. Signed-off-by: Michał Mazurek <mazurekm@google.com> lint of pinmux pinmux pad fixes Signed-off-by: Michał Mazurek <mazurekm@google.com>
6b42a4b to
b221645
Compare
jrvanwhy
previously approved these changes
Oct 25, 2023
bradjc
reviewed
Oct 27, 2023
* Replacing old pinmux reference with Pad and PadConfig. * Improved handling of GPIO LowPower. * Improved handling of GPIO floating state. Signed-off-by: Michał Mazurek <mazurekm@google.com>
8000
mazurek-michal
force-pushed
the
pinmux_gpio_02
branch
from
November 2, 2023 16:59
b221645 to
a9ec1dc
Compare
alistair23
reviewed
Nov 3, 2023
a5238ae to
413a135
Compare
c0047cf to
bc3c467
Compare
|
Connected to OpenTitan task: lowRISC#28 |
jrvanwhy
previously approved these changes
Nov 15, 2023
Following commit introduce new trait that allow to configure Pinmux during board initialization. The new interface allows to configure Pinmux for specific board layout. When new board that uses Ealgrey chip is added user should also implement this trait to provide support for board specific I/O layout. * Add new trait EarlGreyPinmuxConfig for passing baord I/O layout to chip drivers * Add CW310 pinmux layout configuration, compatible with OpenTitan Hyperdebug * Initialize GPIO port based on currently board I/O layout. Signed-off-by: Michał Mazurek <mazurekm@google.com>
bc3c467 to
7523a53
Compare
jrvanwhy
approved these changes
Nov 16, 2023
|
@bradjc Could you check newest version ? |
bradjc
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
padctlwithPadConfigin lowrisc GPIODepend on changes form: (Merged) #3707
Testing Strategy
Manual test using
CW310as DUT andHyperdebugwithopentitantoolas test bench for generating stimulus.
TODO
Documentation Updated
N/A
Formatting
make prepush.