HS3003: Removed Unnecessary Code #3708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please include details in your commits of what you are doing? Why is the current code unnecessary? |
|
The code that was removed was not necessary because according to the datasheet, to wake the sensor and make a measurement, you need to send its i2c address with the write bit set. This is already done by calling |
Because writing is not necessary to read the sensor data, it was changed to just read().
bradjc
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request removes unnecessary code from the
hs3003.rs.Testing Strategy
libtock-cexample programTODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.