8000 clippy: -D clippy::enum_glob_use by bradjc · Pull Request #3644 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

clippy: -D clippy::enum_glob_use #3644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2023
Merged

clippy: -D clippy::enum_glob_use #3644

merged 1 commit into from
Aug 23, 2023

Conversation

bradjc
Copy link
Contributor
@bradjc bradjc commented Aug 23, 2023

Pull Request Overview

This pull request enables the https://rust-lang.github.io/rust-clippy/master/index.html#/enum_g lint.

This should have been enabled long ago.

Testing Strategy

travis

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@bradjc
clippy: -D clippy::enum_glob_use
3be8cdc 
This should have been enabled long ago.
lschuermann
lschuermann approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member
@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate that there's not a more ergonomic way to specify that matches use a given set of enum variants, but I agree that this is better. Specifically it prevents the pitfall of having dangling variants in a match, which are then converted to variables and match on anything.

@ppannuto ppannuto added the P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. label Aug 23, 2023
@ppannuto ppannuto added this pull request to the merge queue Aug 23, 2023
Merged via the queue into master with commit 6541202 Aug 23, 2023
@ppannuto ppannuto deleted the clippy-D-enum_glob_use branch August 23, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brghena brghena brghena approved these changes

@ppannuto ppannuto ppannuto approved these changes

@jrvanwhy jrvanwhy jrvanwhy approved these changes

@lschuermann lschuermann lschuermann approved these changes

Assignees
No one assigned
Labels
P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bradjc @brghena @ppannuto @jrvanwhy @lschuermann
0