Split out (almost) all remaining clippy lints #3632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppannuto
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Once all the clippy dust settles, we should update the comment at the top of this file to reflect the new state of the world.
This one is basically a functional no-op. For the subsequent clippy PRs, is there any order those should try to go in with so they don't conflict with each other?
hudson-ayers
approved these changes
Aug 22, 2023
I haven't done anything to be strategic, just a hope that they aren't touching the same lines of code. |
brghena
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request removes
-A clippy::groupand instead allows individual clippy lints (that we don't meet) so we know which ones we must ignore to have clippy pass.Note, I skipped
-A clippy::restriction. I tried that one, but the lints in that group seem esoteric and not something we will ever try to meet.Testing Strategy
make clippyTODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.