8000 usb: keyboard: do not retry send on ctrl finish by bradjc · Pull Request #3545 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

usb: keyboard: do not retry send on ctrl finish #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

usb: keyboard: do not retry send on ctrl finish #3545

merged 1 commit into from
Jul 20, 2023

Conversation

bradjc
Copy link
Contributor
@bradjc bradjc commented Jul 17, 2023

Pull Request Overview

This pull request removes trying to start a transmission from the ctrl status complete callback in the usb keyboard hid capsule. With this code the nrf52 usb driver crashes because it attempts to re-send a message we have already sent. This only happens if the send occurs while the usb device is being connected.

This is the panic I was getting:

panicked at 'assertion failed: `(left == right)`
  left: `Some(InData)`,
 right: `Some(Init)`', chips/nrf52/src/usbd.rs:1819:13
	Kernel version release-2.1-1294-g8ac0fc427

---| No debug queue found. You can set it with the DebugQueue component.

---| Cortex-M Fault Status |---
No Cortex-M faults detected.

Testing Strategy

Sending USB keyboard data immediately when an app boots.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@bradjc
usb: keyboard: do not retry send on ctrl finish
fb8958c 
With this code the nrf52 usb driver crashes because it attempts to
re-send a message we have already sent. This only happens if the send
occurs while the usb device is being connected.
@alevy alevy added this pull request to the merge queue Jul 19, 2023
Merged via the queue into master with commit f96c4ef Jul 20, 2023
@alevy alevy deleted the usb-keyboard-hid-no-ctrl-complete-retry branch July 20, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alevy alevy alevy approved these changes

@brghena brghena brghena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bradjc @alevy @brghena
0