8000 Basic system clock management for the STM32F4 family by Ioan-Cristian · Pull Request #3528 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Basic system clock management for the STM32F4 family #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 265 commits into from
Sep 22, 2023
Merged

Basic system clock management for the STM32F4 family #3528

merged 265 commits into from
Sep 22, 2023

Conversation

Ioan-Cristian
Copy link
Contributor

Pull Request Overview

This pull request adds support for basic clock management for the STM32F4 family:

  • high-speed internal (HSI) clock configuration
  • main phase-locked loop (PLL) clock configuration
  • Dynamic system clock source and frequency management with system integrity
    checks

Testing Strategy

This pull request was thoroughly tested through unit tests, integration tests
and logic analyzer. The tests were run on STM32F429ZI Nucleo-144 and STM32F446
Nucleo-64 boards.

TODO or Help Wanted

TODO:

  • Add support for high-speed external (HSE) clock
  • Add support for secondary PLL clock

Documentation Updated

  • Updated the relevant files in /docs.

Formatting

  • Ran make prepush.

@Ioan-Cristian
Added full support for PLL48 clock output.
65b6517
@Ioan-Cristian
Updated pll.rs doc
d82e615
@Ioan-Cristian
Updated rcc.rs doc
304559a
@Ioan-Cristian
Added reference in the documentation
d061b1f
@Ioan-Cristian
Ran make prepush
dad36f8
@Ioan-Cristian
Fixed formatting
fc05835
@Ioan-Cristian
Reordered reset configuration values to pass formatting job
6ea8cb0
@Ioan-Cristian
Reordered usage examples
5551402
@Ioan-Cristian
Replaced from() with try_from() + small quality of life changes
c8baa34
@Ioan-Cristian
Replaced hard-coded HSI frequency with const value
bd60cc2
@Ioan-Cristian
Fixed internal docs
5c62445
@Ioan-Cristian
Moved Rcc::init() method inside the constructor
d57411e
@Ioan-Cristian
Fixed formatting
a67fd63
@Ioan-Cristian
Improved internal doc + small quality life of changes
6ce8749
@Ioan-Cristian
Fixed busy waiting values for release mode
897a25b
@Ioan-Cristian
Fixed formatting
350fb13
@Ioan-Cristian
Added HSI clock
7766269
@Ioan-Cristian
Removed old pll.rs and fixed hsi.rs comments
8dbe871
@Ioan-Cristian
Started adding the system clock. Flash peripheral driver is required …
28e6ab7 
…for full implementation
@Ioan-Cristian
Added flash struct + flash latency control. It works only for stm32f4…
570ea70 
…2xx and stm32f43xx models onlygit status!
@Ioan-Cristian
Merged flash-stm32f4xx
96c4eac
@Ioan-Cristian
First implementation of the system clock. It's missing AHB and APB cl…
bac086c 
…ock calibration + additional tests.
@Ioan-Cristian
Changed LatencyValue name to FlashLatency + restructed sys_clock + ne…
cf96f75 
…w tests
@Ioan-Cristian
Added APB1 support
fd30331
@Ioan-Cristian
Added APB2 support
16ded35
@Ioan-Cristian
Added APB1 and APB2 frequency limits for all possible models
dd3632a
@Ioan-Cristian
Replaced hard-coded constants with const variables
8891f30
@Ioan-Cristian
Added rustc flag to compile the project
0fd3eec
@Ioan-Cristian
Added system clock const values based on rustc flags + HSI frequency …
94ec6ae 
…const value
@Ioan-Cristian
Split test_clocks_struct based on the chip model
644185a
@Ioan-Cristian
Copy link
Contributor Author

Hello!

As discussed last Friday, I reimplemented this pull request using type parameters and trait bounds. What do you think about it? @bradjc @ppannuto

Note that documentation is still missing. I'll fix that once the changes are approved.

Also, tests still rely on features. Probably I'll reimplement them using the same strategy as for the implementation itself.

bradjc
bradjc reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor
@bradjc bradjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is great.

One question, should the chip-specific implementations go in the specific chip crates? Is there a benefit to centralizing them?

@Ioan-Cristian
Copy link
Contributor Author

Wow this is great.

One question, should the chip-specific implementations go in the specific chip crates? Is there a benefit to centralizing them?

Hmm, good question. I assumed that you wanted them to be centralized just like as with features. There might be a small benefit from implementing them in the stm32f4xx crate: the respective modules can be made pub(crate), exposing to the other crates just ChipSpecs trait. This can help in hiding implementation details giving more freedom to change them in the future. However, both solutions seem fine to me. As a side note, I first implemented them in the chip-specific crates.

@bradjc
Copy link
Contributor
bradjc commented Sep 20, 2023

I think from the perspective of "if I'm updating/creating a specific variant, I shouldn't have to change the shared crate" it would make sense to me to put the chip-specific content in the specific crates.

@Ioan-Cristian
Copy link
Contributor Author

Moved all ChipSpecs implementations to chip-specific crates.

@bradjc bradjc added the last-call Final review period for a pull request. label Sep 20, 2023
@bradjc bradjc added this pull request to the merge queue Sep 22, 2023
Merged via the queue into tock:master with commit dd844b6 Sep 22, 2023
@Ioan-Cristian Ioan-Cristian mentioned this pull request Sep 28, 2023
Merged
2 tasks
@Ioan-Cristian Ioan-Cristian mentioned this pull request Nov 9, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradjc bradjc bradjc approved these changes

@brghena brghena brghena left review comments

@ppannuto ppannuto Awaiting requested review from ppannuto

Assignees
No one assigned
Labels
last-call Final review period for a pull request. stm32 Change pertains to the stm32 family of MCUSs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ioan-Cristian @bradjc @brghena @ppannuto
0