Add hmac-sha256 software capsule #3502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased. |
ppannuto
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
I believe this all looks correct.
Long term, the near-duplication of implementation (e.g. add_data vs add_mut_data) up and down the security/crypto ecosystem based on whether it's an in-place or two buffer feels fragile, but I don't have a better thought at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds an HMAC-sha256 capsule and a simple test.
Testing Strategy
Running the test on the nrf52840dk.
TODO or Help Wanted
This requires the update to the digest trait.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.