nRF52 AES Improvements #3448
Merged
nRF52 AES Improvements #3448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
reviewed
May 25, 2023
Comment on lines
+752
to
+822
| // test::aes_test::run_aes128_ctr(&base_peripherals.ecb); | ||
| // test::aes_test::run_aes128_cbc(&base_peripherals.ecb); | ||
| // test::aes_test::run_aes128_ecb(&base_peripherals.ecb); |
There was a problem hiding this comment.
Why not use the unit test framework to run these instead of commenting them out?
There was a problem hiding this comment.
That's the right thing to do but not something I'm going to take on right now.
alistair23
reviewed
May 25, 2023
We can store the results in-place in the output buffer, removing the artificial limit in the driver implementation.
|
Rebased. Ready to go again. |
ppannuto
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request:
Adds the userspace AES driver to the nRF52840dk board.Note, the nRF52 ECB module does not support decryption, so the ECB and CBC decryption tests fail.
This pull request is me getting familiar with the AES support on the nRF52 in hopes of using it for the Tock Tutorial.
Testing Strategy
Running the kernel AES tests.
TODO or Help Wanted
When I run the libtock-c/aes test app, I get:
So the AES CTR works, but the CCM does not. I did not change any of the CCM code. Do we know if that test is supposed to work? I believe the userland test app uses a different size IV than the in-kernel CCM test.Nevermind, since we don't have GCM we cannot use the userspace driver.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.