boards: nrf52840dk: fix ctap example code #3439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we had the CTAP code commented out, it didn't get updated when the component did.
alistair23
approved these changes
May 22, 2023
ppannuto
approved these changes
Jun 8, 2023
bors bot
added a commit
that referenced
this pull request
Jun 8, 2023
3439: boards: nrf52840dk: fix ctap example code r=ppannuto a=bradjc ### Pull Request Overview Since we had the CTAP code commented out, it didn't get updated when the component did. ### Testing Strategy compiling ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. 3443: make: llvm-tools no longer preview r=ppannuto a=bradjc ### Pull Request Overview Without this change I was getting: ``` $ make info: component 'llvm-tools' for target 'x86_64-apple-darwin' is up to date ``` on every build. It seems llvm-tools is now a real thing, and no longer a preview. ### Testing Strategy running make ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. 3444: kernel: minor updates to platform.rs r=ppannuto a=bradjc - Reorder the context switch callback getter to match the type def. - Cleanup comments. Minor fixes as I'm looking at (and writing about) this file. ### Testing Strategy n/a ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. 3456: capsules: tickv: do operation after init on already init r=ppannuto a=bradjc ### Pull Request Overview With tickv, if the KV store is already initialized, and a board runs an operation right away, the operation would get queued waiting on the init to finish, but if the init finishes without having to do anything (already inited), the queued operation would never run. This fixes that. ### Testing Strategy testing out tickv on nrf52840dk ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Brad Campbell <bradjc5@gmail.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: Response status code: 422
{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Since we had the CTAP code commented out, it didn't get updated when the component did.
Testing Strategy
compiling
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.