8000 Updated instructions on running HiFive under qemu by alevy · Pull Request #1783 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updated instructions on running HiFive under qemu #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

alevy
Copy link
Member
@alevy alevy commented Apr 22, 2020

Pull Request Overview

Updates the Makefile and README for the HiFive board to provide more complete instructions for running Tock on the HiFive board under qemu with an application.

It also adds qemu to the Nix shell

Testing Strategy

Repeating the steps in the README and getting a nice "Hello World" on the console

TODO or Help Wanted

N/A

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make formatall.

@alevy alevy requested review from alistair23 and bradjc April 22, 2020 13:31
@alevy alevy changed the title Updated instructions on runnin HiFive under qemu Updated instructions on running HiFive under qemu Apr 22, 2020
Copy link
Member
@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

One documentation comment, take it or leave it

Or with the `qemu` make target:

```bash
$ make qemu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In both cases, should the command invocation be duplicated, or should the documentation just direct folks to call make and let what make executes be self-documenting (worried the doc will fall out of sync / the command here provides relatively little value, unless it's changed often?)

@bors
Copy link
Contributor
bors bot commented Apr 22, 2020

✌️ alevy can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bradjc bradjc mentioned this pull request Apr 22, 2020
69 tasks
@bradjc bradjc merged commit f1f9d71 into tock:master Apr 22, 2020
@alevy alevy deleted the hifive branch February 29, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0