8000 Deployment Versioning Updates by Alex-Tideman · Pull Request #2764 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deployment Versioning Updates #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 16, 2025
Merged

Deployment Versioning Updates #2764

merged 14 commits into from
Jun 16, 2025

Conversation

Alex-Tideman
Copy link
Contributor
@Alex-Tideman Alex-Tideman commented Jun 11, 2025

Description & motivation 💭

Adds additional information from updated versioning API.

  • Changes Version to Build ID column in Deployments table and Deployment table.
  • Adds Ramping Version with timestamp.
  • Adds Ramping/Current Since timestamp.
  • Add Latest Build ID if it exists and is not the same as Ramping Build Id.
  • Adds copyable/filterable functionality to Deployment/Deployment Version/Versioning Behavior in Workflow List table. Will add Version Build ID when server adds it.
  • Change Deployment Version to Build ID in Workflow header details.
  • Adds link to Deployment page in Worker table.
  • Change link to Task Queue page on task queue Workflow Details link.
  • Updates to Public Preview tag
  • Updates to api v1.50.0

Screenshots (if applicable) 📸

New Actions column header
Screenshot 2025-06-11 at 12 07 56 PM
Screenshot 2025-06-11 at 12 14 47 PM
Screenshot 2025-06-11 at 10 36 21 AM
Screenshot 2025-06-11 at 11 10 12 AM
Screenshot 2025-06-11 at 9 45 48 AM
Screenshot 2025-06-11 at 9 46 17 AM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman Alex-Tideman requested review from rossedfort and a team as code owners June 11, 2025 15:02
Copy link
vercel bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 3:02pm

@Alex-Tideman Alex-Tideman merged commit 1753c26 into main Jun 16, 2025
16 checks passed
@Alex-Tideman Alex-Tideman deleted the deployments-updates branch June 16, 2025 18:47
Alex-Tideman added a commit that referenced this pull request Jun 17, 2025
* Svelte5 updates, cleanup. Need new API to convert deployment stuff

* Update deploys SAs to be filter/copyable, add Build Ids everywhere. Add new types

* Fix columns and headers to not have status as column

* Fix table widths, link to task queue show since current/ramping

* Remove console.log, add unit tests for version

* Set width and text-right on link column

* Add latest deployment build id and svelte5

* Use correct translation for ramping version

* Remove comment

* Update column to Actions and update link label

* Show __unversioned__, check if latestId is currentId

* Move back to Pre-Release tag
Alex-Tideman added a commit that referenced this pull request Jun 25, 2025
* Add function to determine billableAction count

* Make the event history table better

* Add date to pending activity

* Add line-dot visualization back

* Remove borders, more table stuff

* Event Card

* Table changes

* WIP: icon placeholder and isCloud check

* Add dollar-invoice icon

* Show row details on Timeline to make them consistent

* Change grid if no payloads

* Fix timestamp and copyable button

* Fix type, comment out visibility store

* Use h-9 for the table header cell height to prevent shift on bulk actions

* Make title text bigger

* Update Card styles, add event links

* Include workflow rejected action

* Flip visibility to test

* Clean up cards

* Hide redudent fields

* Pending Activities fixes

* Update s
8AEB
ignal count on id

* UI improvements

* Add PendingNexusOperationCard

* Add check for WorkflowTaskFailedEvent due to reset and update billable actions accordingly

* Refactor to add shouldNotAddBillableAction check instead of resetBillableActionsBeforeEvent

* Fix formatDate to account for already formated date strings

* Use findLast for isWorkflowTaskFailedEventDueToReset

* Reset isCloud

* Event row UI improvements

* More UI fixes

* Remove borders on tables

* Remove nested css for ui-server (#2767)

* Deployment Versioning Updates (#2764)

* Svelte5 updates, cleanup. Need new API to convert deployment stuff

* Update deploys SAs to be filter/copyable, add Build Ids everywhere. Add new types

* Fix columns and headers to not have status as column

* Fix table widths, link to task queue show since current/ramping

* Remove console.log, add unit tests for version

* Set width and text-right on link column

* Add latest deployment build id and svelte5

* Use correct translation for ramping version

* Remove comment

* Update column to Actions and update link label

* Show __unversioned__, check if latestId is currentId

* Move back to Pre-Release tag

* Create Version Bump PR as Draft (#2769)

Some of the required checks dont run when its generated by github actions. The
always draft trick worked in cloud so lets try that in ui as well. This also
sets the author and committer to the user who created the PR.

* chore: bump version to 2.38.0 (#2770)

Auto-generated version bump from 2.37.2 to 2.38.0

Bump type: minor

Changes included:\nManual version bump

Co-authored-by: Alex-Tideman <7967403+Alex-Tideman@users.noreply.github.com>

* Revert #2709 due to CORS Issues (#2772)

* chore: bump version to 2.38.1 (#2773)

Auto-generated version bump from 2.38.0 to 2.38.1

Bump type: patch

Changes included:\nManual version bump

Co-authored-by: Alex-Tideman <7967403+Alex-Tideman@users.noreply.github.com>

* Make w-1/2 for event card split, fix summary field alignment

* Fix empty row colspan

* Update billing logic, remove dollar-invoice icon

* Check for version change SA

* Update event card spacing

* Update billing logic for schedules, add comments, more event card css

* Fix logic

* Better optional chaining

* Schedule count to 3, remove external signal

* Update to Billable Actions label

* More card spacing updates

* Remove Workers/Versioning tab on task queue page (#2783)

---------

Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io>
Co-authored-by: Ross Nelson <ross.nelson@temporal.io>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0