8000 Billable Actions and Event History Table / Timeline updates by Alex-Tideman · Pull Request #2758 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Billable Actions and Event History Table / Timeline updates #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Jun 25, 2025
Merged

Billable Actions and Event History Table / Timeline updates #2758

merged 56 commits into from
Jun 25, 2025

Conversation

Alex-Tideman
Copy link
Contributor
@Alex-Tideman Alex-Tideman commented Jun 3, 2025 •
edited
Loading

Description & motivation 💭

For Cloud only, labels events in the Event History with Billable Action count. Includes total Billable Action count in the workflow header.

Other changes:

  • Makes the Event History table an actual table
  • Moves the Lines/Dots out of the Event History table and only shows them when in “Expanded” mode
  • Makes Event Details (expanded event row or expanded in Timeline) to be consistently styled cards
  • Hides certain duplicate fields on Event Details (e.g. scheduled/started/initiated event IDs, Namespace, Namespace ID)

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

  • Waiting on confirmation from Cloud team on counts

Issue(s) closed

DT-2916
DT-2982
DT-2985

Docs

Any docs updates needed?

@vercel Vercel
Copy link
vercel bot commented Jun 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 4:18pm

rossedfort
rossedfort approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor
@rossedfort rossedfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a couple minor suggestions

@Alex-Tideman Alex-Tideman marked this pull request as draft June 18, 2025 17:16
mastermanu
mastermanu reviewed Jun 20, 2025
View reviewed changes
mastermanu
mastermanu reviewed Jun 20, 2025
View reviewed changes
@Alex-Tideman Alex-Tideman requested a review from mastermanu June 20, 2025 15:34
@Alex-Tideman Alex-Tideman marked this pull request as ready for review June 24, 2025 14:43
@Alex-Tideman Alex-Tideman merged commit 258ee5b into main Jun 25, 2025
16 checks passed
@Alex-Tideman Alex-Tideman deleted the billable-actions-table branch June 25, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossedfort rossedfort rossedfort approved these changes

@andrewzamojc andrewzamojc Awaiting requested review from andrewzamojc

@laurakwhit laurakwhit Awaiting requested review from laurakwhit

@rossnelson rossnelson Awaiting requested review from rossnelson

@mastermanu mastermanu Awaiting requested review from mastermanu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Alex-Tideman @mastermanu @rossedfort @laurakwhit @rossnelson
0