8000 Add various small refactorings by tranzystorekk · Pull Request #201 · tealdeer-rs/tealdeer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ tealdeer Public
  • < 8000 a href="/login?return_to=%2Ftealdeer-rs%2Ftealdeer" rel="nofollow" id="repository-details-watch-button" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"notification subscription menu watch","repository_id":null,"auth_type":"LOG_IN","originating_url":"https://github.com/tealdeer-rs/tealdeer/pull/201","user_id":null}}" data-hydro-click-hmac="a1e39bccba63fc7728de505e781c3223a58f1037555064c930bed59062b308ad" aria-label="You must be signed in to change notification settings" data-view-component="true" class="btn-sm btn"> Notifications You must be signed in to change notification settings
  • Fork 132
  • Star 5k

Add various small refactorings #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2021
Merged

Add various small refactorings #201

merged 2 commits into from
Aug 29, 2021

Conversation

tranzystorekk
Copy link
Contributor

Highlights:

  • Remove redundant .iter() / .into_iter() calls
  • Use arrays and their new IntoIterator impl (instead of vecs/slices)
  • Remove redundant .as_bytes() calls

dbrgn
dbrgn approved these changes Aug 29, 2021
View reviewed changes
Copy link
Collaborator
@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! Looks good from my side, can be merged as soon as tests pass.

@dbrgn dbrgn changed the title Add various small refactors Add various small refactorings Aug 29, 2021
@tranzystorekk
Copy link
Contributor Author

Ah, the IntoIterator impl for arrays is available from Rust 1.53, and I see 1.52 in CI 😕

@dbrgn
Copy link
Collaborator
dbrgn commented Aug 29, 2021

As per #191, feel free to bump the Rust version in CI! (It would be great if you could also reorder the commits so that the version bump commit comes first, in case you know how to do that.)

@tranzystorekk
Copy link
Contributor Author

Done 😀

dbrgn
dbrgn requested changes Aug 29, 2021
View reviewed changes
Copy link
Collaborator
@dbrgn dbrgn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, one last thing: Can you also update the version in clippy.toml (ideally in the same commit as the CI version bump)? (I hope this doesn't trigger new lints though.)

@dbrgn dbrgn merged commit 4e0d497 into tealdeer-rs:master Aug 29, 2021
@tranzystorekk tranzystorekk deleted the refactor-misc branch August 29, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrgn dbrgn dbrgn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tranzystorekk @dbrgn
0