8000 Update MSRV policy by dbrgn · Pull Request #191 · tealdeer-rs/tealdeer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update MSRV policy #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2021
Merged

Update MSRV policy #191

merged 2 commits into from
May 13, 2021

Conversation

dbrgn
Copy link
Collaborator
@dbrgn dbrgn commented May 12, 2021

Here's the updated policy, as discussed in #190.

Closes #190.

@dbrgn
Update MSRV policy
3223fec 
As discussed in #190.
@dbrgn dbrgn requested a review from niklasmohrin May 12, 2021 22:07
@dbrgn
Copy link
Collaborator Author
dbrgn commented May 12, 2021

I also bumped the Rust version in CI to 1.52. I still think there's value in having a lower bound in the CI config, but we can now bump it more freely if building fails.

niklasmohrin
niklasmohrin approved these changes May 13, 2021
View reviewed changes
Copy link
Collaborator
@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good rule 👍

I would like to point out two things:

  1. I think we shouldn't pin the patch version of MSRV, we can just say 1.52
  2. we could have the msrv as a constant at the top to remove duplication (see https://www.github.com/sharkdp/bat/tree/master/.github%2Fworkflows%2FCICD.yml)

@dbrgn
Copy link
Collaborator Author
dbrgn commented May 13, 2021

I think we shouldn't pin the patch version of MSRV, we can just say 1.52

Good point!

we could have the msrv as a constant at the top to remove duplication

Again, good point. I'll update my second commit.

@dbrgn dbrgn force-pushed the msrv branch 3 times, most recently from bf3a878 to 93e20e2 Compare May 13, 2021 12:29
@dbrgn
Copy link
Collaborator Author
dbrgn commented May 13, 2021

Unfortunately using a variable doesn't work, so I'll have to revert that.

@dbrgn dbrgn merged commit a72ba4a into master May 13, 2021
@dbrgn dbrgn deleted the msrv branch May 13, 2021 12:45
@dbrgn dbrgn mentioned this pull request Aug 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasmohrin niklasmohrin niklasmohrin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: Tealdeer MSRV Policy
2 participants
@dbrgn @niklasmohrin
0