8000 Add store, callbacks prop to Provider by Lunuy · Pull Request #4 · teafuljs/teaful · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add store, callbacks prop to Provider #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add store, callbacks prop to Provider #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { useState, useContext, createContext } from "react";

export default function createStore(store = {}, callbacks = {}) {
const keys = Object.keys(store);
export default function createStore(defaultStore = {}) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the option to generate callbacks also outside the Provider level. This way there are both options.

Suggested change
export default function createStore(defaultStore = {}) {
export default function createStore(defaultStore = {}, defaultCallbacks = {}) {

const keys = Object.keys(defaultStore);
const capitalize = (k) => `${k[0].toUpperCase()}${k.slice(1, k.length)}`;

// storeUtils is the object we'll return with everything
Expand All @@ -10,7 +10,7 @@ export default function createStore(store = {}, callbacks = {}) {
// We initialize it by creating a context for each property and
// returning a hook to consume the context of each property
const storeUtils = keys.reduce((o, key) => {
const context = createContext(store[key]); // Property context
const context = createContext([defaultStore[key], () => console.error('You can\'t change store value because store provider not found.')]); // Property context
const keyCapitalized = capitalize(key);

if (keyCapitalized === "Store") {
Expand All @@ -29,7 +29,7 @@ export default function createStore(store = {}, callbacks = {}) {
}, {});

// We create the main provider by wrapping all the providers
storeUtils.Provider = ({ children }) => {
storeUtils.Provider = ({ store, callbacks = {}, children }) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add a default object to avoid a crash on line 36 if is not defined:

Suggested change
storeUtils.Provider = ({ store, callbacks = {}, children }) => {
storeUtils.Provider = ({ store = {}, callbacks = {}, children }) => {

And in line 36 I would change this:

const [value, setter] = useState(store[key]);

to:

const [value, setter] = useState(store[key] || defaultStore[key]);

And in line 37:

const cb = callbacks[key];

to

const cb = callbacks[key] || defaultCallbacks[key];

const Empty = ({ children }) => children;
const Component = storeUtils.contexts
.map(({ context, key }) => ({ children }) => {
Expand Down
0