Add store, callbacks prop to Provider #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aralroca
reviewed
Oct 2, 2021
| @@ -1,7 +1,7 @@ | |||
| import React, { useState, useContext, createContext } from "react"; | |||
|
|
|||
| export default function createStore(store = {}, callbacks = {}) { | |||
| const keys = Object.keys(store); | |||
| export default function createStore(defaultStore = {}) { | |||
There was a problem hiding this comment.
I would put the option to generate callbacks also outside the Provider level. This way there are both options.
Suggested change
| export default function createStore(defaultStore = {}) { | |
| export default function createStore(defaultStore = {}, defaultCallbacks = {}) { |
8000
index.js
| @@ -29,7 +29,7 @@ export default function createStore(store = {}, callbacks = {}) { | |||
| }, {}); | |||
|
|
|||
| // We create the main provider by wrapping all the providers | |||
| storeUtils.Provider = ({ children }) => { | |||
| storeUtils.Provider = ({ store, callbacks = {}, children }) => { | |||
There was a problem hiding this comment.
You forgot to add a default object to avoid a crash on line 36 if is not defined:
Suggested change
| storeUtils.Provider = ({ store, callbacks = {}, children }) => { | |
| storeUtils.Provider = ({ store = {}, callbacks = {}, children }) => { |
And in line 36 I would change this:
const [value, setter] = useState(store[key]);to:
const [value, setter] = useState(store[key] || defaultStore[key]);And in line 37:
const cb = callbacks[key];to
const cb = callbacks[key] || defaultCallbacks[key];|
I close the PR because I have reimplemented everything and I have taken this into account :) Now you can fragment at any level and the hooks are now with a proxy and can be used as follows: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
What changes did you make? (Give an overview)
New feature: Add store, callbacks field to Provider.
Other: Now can read only access to store when hook can't find appropriate Provider.
This is breaking change.