8000 Update documentation with new dialects by mchen-codaio · Pull Request #6337 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update documentation with new dialects #6337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2024
Merged

Update documentation with new dialects #6337

merged 2 commits into from
Oct 17, 2024

Conversation

mchen-codaio
Copy link
Contributor

Brief summary of the change made

Add new dialects from #5979 into documentation. Companion to #5964

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

I don't think I need to test anything for documentation?

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Oct 11, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18590      0   100%

236 files skipped due to complete coverage.

@alanmcruickshank
Copy link
Member

@mchen-codaio - Welcome to the project! Looks like there are a couple of linting fails here. I think you've got some trailing whitespace at the end of one line and the indentation of the second looks off.

Also, if you're up for a little scope creep, I saw this comment in the original issue, which asks whether we can include Trino in this list too. I've confirmed that Trino supports UNION DISTINCT in their docs here: https://trino.io/docs/current/sql/select.html

Do you need any help getting this PR ready for review?

@mchen-codaio mchen-codaio force-pushed the mchen-codaio-ambiguous-union-docs branch from 2fe1d63 to f2e84fc Compare October 16, 2024 21:26
@mchen-codaio
Copy link
Contributor Author

@alanmcruickshank thanks for the tip! I tried to fix the whitespace. Assuming this one goes well then I can make a follow-up PR to add Trino.

Personally I would love to see this in Snowflake as with this comment. UNION DISTINCT is not in their official documentation but it works and it's helpful. I found a bug in some other code where a UNION should have been UNION ALL - adding the word would make it more explicit.

@alanmcruickshank
Copy link
Member

@alanmcruickshank thanks for the tip! I tried to fix the whitespace. Assuming this one goes well then I can make a follow-up PR to add Trino.

Personally I would love to see this in Snowflake as with this comment. UNION DISTINCT is not in their official documentation but it works and it's helpful. I found a bug in some other code where a UNION should have been UNION ALL - adding the word would make it more explicit.

Agreed, if you could add snowflake too that would be excellent. 👍

alanmcruickshank
alanmcruickshank approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member
@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@alanmcruickshank alanmcruickshank marked this pull request as ready for review October 17, 2024 08:40
@alanmcruickshank alanmcruickshank added this pull request to the merge queue Oct 17, 2024
Merged via the queue into sqlfluff:main with commit 5146909 Oct 17, 2024
28 checks passed
@mchen-codaio mchen-codaio mentioned this pull request Oct 17, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mchen-codaio @alanmcruickshank
0