8000 Enable AM02 for snowflake and trino by default. by mchen-codaio · Pull Request #6369 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable AM02 for snowflake and trino by default. #6369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2024
Merged

Enable AM02 for snowflake and trino by default. #6369

merged 1 commit into from
Oct 20, 2024

Conversation

mchen-codaio
Copy link
Contributor
@mchen-codaio mchen-codaio commented Oct 17, 2024 •
edited
Loading

Brief summary of the change made

Based on conversation in #6337 (comment) and in #5964 (comment), this PR expands coverage of the ambiguous union rule (AM02) to Snowflake and Trino.

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Ran linter and tox check for this rule, AM02

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18605      0   100%

236 files skipped due to complete coverage.

@mchen-codaio mchen-codaio marked this pull request as ready for review October 18, 2024 18:43
@alanmcruickshank alanmcruickshank changed the title support snowflake and trino for ambiguous union Enable AM02 for snowflake and trino by default. Oct 20, 2024
alanmcruickshank
alanmcruickshank approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member
@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good to me! Thanks for this 👍

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Oct 20, 2024
Merged via the queue into sqlfluff:main with commit a5e0549 Oct 20, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mchen-codaio @alanmcruickshank
0