Issues 187 203 1059 command line improvements #1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FrankRay78 This might seem odd, but could you send me an email at |
This was
linked to
issues
Dec 11, 2022
c5a463b to
9386451
Compare
025c46b to
5ea59b9
Compare
5ea59b9 to
227345c
Compare
227345c to
6ab8183
Compare
patriksvensson
requested changes
Mar 1, 2023
src/Spectre.Console.Cli/Internal/Modelling/CommandModelBuilder.cs
Outdated
Show resolved
Hide resolved
test/Spectre.Console.Cli.Tests/Unit/CommandModelBuilderTests.cs
Outdated
Show resolved
Hide resolved
…toryInfo (spectreconsole#1145) Add support for converting command parameters that doesn't have a built-in TypeConverter but has a constructor that takes a string. For CLI apps, FileInfo and DirectoryInfo will likely be the most useful ones, but there may be others.
…rtFlagsToRemainingArguments for readability
…CommandModelBuilder unit tests and replaced these with increased coverage in CommandAppTests.Xml
…rtFlagsToRemainingArguments for readability
…CommandModelBuilder unit tests and replaced these with increased coverage in CommandAppTests.Xml
|
Hi @patriksvensson, is there anything more required from myself regarding this PR? I've had an initial pass regarding addressing all your review comments, and pushed these changes to the branch. Let me know if you require anything further. |
patriksvensson
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** This PR contains the following PRs I've worked on - #1101, #1070, #1102, rebased, merged together and with conflicts resolved ***
The following issues are addressed by the individual PRs listed above:
#187, 'Allow default command configuration for a branch'
#203, 'Simple switches end up on "remaining" list even if parsed properly'
#1059, 'Ability to add command line flags and their values to remaining arguments if they cannot be set on the settings class'
Together they seem like a reasonable parcel of command line improvements, and so I've grouped them together here for ease of reviewing (should they wish to be released together).