8000 187 Allow default command configuration for a branch by FrankRay78 · Pull Request #1101 · spectreconsole/spectre.console · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

187 Allow default command configuration for a branch #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

FrankRay78
Copy link
Contributor

This PR fully addresses #187, 'Allow default command configuration for a branch'.

Existing unit tests involving branch commands have been split out into a separate class, CommandAppTests+Branches and several new unit tests have been implemented to adequately cover the new default command configuration for a branch functionality.

Additionally, some unit test coverage of CommandModelBuilder (which didn't previously exist) has been added.

8000
@FrankRay78 FrankRay78 changed the title Allow default command configuration for a branch (#187) 187 Allow default command configuration for a branch Dec 7, 2022
@FrankRay78
Copy link
Contributor Author

FYI - This PR has been bundled in #1103, should it wish to be reviewed/merged alongside related issues. If so, this PR should be closed with no further action.

@FrankRay78
Copy link
Contributor Author

I'm closing this PR as it's been bundled into #1103 and it's too onerous for me to keep rebasing this, and the other bundled PR's, to keep up with the upstream/main branch as it moves forward with various other commits.

@FrankRay78 FrankRay78 closed this Mar 1, 2023
@FrankRay78 FrankRay78 deleted the 187-Allow-default-command-configuration-for-a-branch branch April 3, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0