8000 Support for hierarchical directory structures for experiments. by ttung · Pull Request #1126 · spacetx/starfish · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support for hierarchical directory structures for experiments. #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2019
Merged

Support for hierarchical directory structures for experiments. #1126

8000 merged 1 commit into from
Apr 3, 2019

Conversation

ttung
Copy link
Collaborator
@ttung ttung commented Apr 2, 2019

Pick up spacetx/slicedimage#85, spacetx/slicedimage#86, and spacetx/slicedimage#87.

Code changes to support the API changes.

This will not pass travis until the above PRs are approved, landed, and a new slicedimage package is released.

Test plan: make -j fast
Partially addresses #1116

@ttung ttung requested review from shanaxel42 and kne42 April 2, 2019 18:36
@ttung ttung mentioned this pull request Apr 2, 2019
Merged
@codecov-io
Copy link
codecov-io commented Apr 3, 2019 •
edited
Loading

Codecov Report

Merging #1126 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files         125      125           
  Lines        4562     4562           
=======================================
  Hits         4123     4123           
  Misses        439      439
Impacted Files Coverage Δ
starfish/imagestack/imagestack.py 93.25% <100%> (ø) ⬆️
starfish/experiment/builder/__init__.py 94.54% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83384e4...73b8a18. Read the comment docs.

Support for hierarchical directory structures for experiments.
73b8a18 
Pick up spacetx/slicedimage#85, spacetx/slicedimage#86, and spacetx/slicedimage#87.

Code changes to support the API changes.

Test plan: `make -j fast`
Fixes #1116
@ttung ttung force-pushed the tonytung-hierarchical-directories branch from d8a455e to 73b8a18 Compare April 3, 2019 06:01
@ttung ttung merged commit 6520420 into master Apr 3, 2019
@ttung ttung deleted the tonytung-hierarchical-directories branch April 3, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanaxel42 shanaxel42 shanaxel42 approved these changes

@kne42 kne42 Awaiting requested review from kne42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttung @codecov-io @shanaxel42
0