Permit writing of images to hierarchical on-disk representations. #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=========================================
Coverage ? 74.88%
=========================================
Files ? 20
Lines ? 669
Branches ? 0
=========================================
Hits ? 501
Misses ? 168
Partials ? 0
Continue to review full report at Codecov.
|
shanaxel42
approved these changes
Apr 2, 2019
4e759d7 to
6d39d65
Compare
Rather than writing the basename of a referenced file, calculate the relative path from the current file and record that. Adds a test to verify that such behavior works. This is the last piece of slicedimage work necessary for spacetx/starfish#1116
6d39d65 to
b69dbaf
Compare
ttung
added a commit
to spacetx/starfish
that referenced
this pull request
Apr 3, 2019
Pick up spacetx/slicedimage#85, spacetx/slicedimage#86, and spacetx/slicedimage#87. Code changes to support the API changes. Test plan: `make -j fast` Fixes #1116
ttung
added a commit
that referenced
this pull request
Apr 22, 2019
Rather than writing the basename of a referenced file, calculate the relative path from the current file and record that. Adds a test to verify that such behavior works. This is the last piece of slicedimage work necessary for spacetx/starfish#1116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than writing the basename of a referenced file, calculate the relative path from the current file and record that. Adds a test to verify that such behavior works.
This is the last piece of slicedimage work necessary for spacetx/starfish#1116
Depends on #86