8000 JP-2305 added regression tests for cube_build internal_cal type IFU cubes by jemorrison · Pull Request #6405 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2305 added regression tests for cube_build internal_cal type IFU cubes #6405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2021
Merged

JP-2305 added regression tests for cube_build internal_cal type IFU cubes #6405

merged 3 commits into from
Oct 21, 2021

Conversation

jemorrison
Copy link
Collaborator
@jemorrison jemorrison commented Oct 20, 2021 •
edited by hbushouse
Loading

Closes #6403
Resolves JP-2305

Description

This PR adds a regression test for MIRI and NIRSpec for internal cal type IFU cubes.

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@jemorrison
Copy link
Collaborator Author

I have put the input and truth files on artifactory for these 2 tests and tested them.
Do we add reg test to change logs - I don't remember.

@codecov
Copy link
codecov bot commented Oct 20, 2021 •
edited
Loading

Codecov Report

Merging #6405 (0d000ad) into master (39f72fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6405   +/-   ##
=======================================
  Coverage   77.71%   77.71%           
=======================================
  Files         408      408           
  Lines       34936    34936           
=======================================
  Hits        27149    27149           
  Misses       7787     7787
Flag Coverage Δ *Carryforward flag
nightly 77.69% <ø> (ø) Carriedforward from 39f72fc
unit 56.34% <ø> (+0.33%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f72fc...0d000ad. Read the comment docs.

@hbushouse hbushouse added this to the Build 7.9 milestone Oct 20, 2021
@hbushouse
Copy link
Collaborator

I have put the input and truth files on artifactory for these 2 tests and tested them. Do we add reg test to change logs - I don't remember.

No change log entry needed for regtests

hbushouse
hbushouse reviewed Oct 20, 2021
View reviewed changes
@jemorrison
Copy link
Collaborator Author

I fixed a mistake I made yesterday. I overwrote an existing input file to another test. I got the old version of the file from snap shot of 1.3.3. I am now using that file for testing the miri internal_cal ifu tests. Using that file I created new truth files to use for this test and put them on artifactory

@hbushouse hbushouse merged commit f69d493 into spacetelescope:master Oct 21, 2021
nden pushed a commit to nden/jwst that referenced this pull request Nov 2, 2021
@jemorrison @nden
JP-2305 added regression tests for cube_build internal_cal type IFU c…
345b079 
…ubes (spacetelescope#6405)

* added reg test for internal_cal

* Change names of tests

* Updated change log for a missing entry for spacetelescope#6387
nden pushed a commit to nden/jwst that referenced this pull request Nov 2, 2021
@jemorrison @nden
JP-2305 added regression tests for cube_build internal_cal type IFU c…
851c5c6 
…ubes (spacetelescope#6405)

* added reg test for internal_cal

* Change names of tests

* Updated change log for a missing entry for spacetelescope#6387
@jemorrison jemorrison deleted the regtest_internal branch November 4, 2021 22:03
loicalbert pushed a commit to talensgj/jwst that referenced this pull request Nov 5, 2021
@jemorrison @loicalbert
JP-2305 added regression tests for cube_build internal_cal type IFU c…
cef40d9 
…ubes (spacetelescope#6405)

* added reg test for internal_cal

* Change names of tests

* Updated change log for a missing entry for spacetelescope#6387
@stscijgbot-jp stscijgbot-jp mentioned this pull request Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

@stscieisenhamer stscieisenhamer Awaiting requested review from stscieisenhamer

Assignees
No one assigned
Labels
cube_build regression_testing
Projects
None yet
Milestone
Build 7.9
Development

Successfully merging this pull request may close these issues.

Add a regression test for cube_build internal_cal type cubes
2 participants
@jemorrison @hbushouse
0