JP-2294: Residual fringe documentation #6387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Repor 8000 t
@@ Coverage Diff @@
## master #6387 +/- ##
==========================================
- Coverage 77.25% 76.80% -0.45%
==========================================
Files 409 409
Lines 35070 35762 +692
==========================================
+ Hits 27092 27468 +376
- Misses 7978 8294 +316
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
hbushouse
reviewed
Oct 11, 2021
|
I made the changes, but I realize I also need to update the calwebb_spec3 processing table and add an entry for residual_fringe step |
|
All changes have been made from review |
hbushouse
reviewed
Oct 11, 2021
<
8000
/div>
hbushouse
reviewed
Oct 12, 2021
hbushouse
approved these changes
Oct 21, 2021
|
Looks good now. Just needs a change log entry and it'll be ready to merge. |
|
Still needs a change log entry, which was requested above. |
|
Whoops too eager to get it merged I missed that comment.
…________________________________
From: Howard Bushouse ***@***.***>
Sent: Thursday, October 21, 2021 7:41 AM
To: spacetelescope/jwst ***@***.***>
Cc: Jane Morrison ***@***.***>; State change ***@***.***>
Subject: [EXT]Re: [spacetelescope/jwst] JP-2294: Residual fringe documentation (#6387)
External Email
External Email
Still needs a change log entry, which was requested above.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#6387 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AENCOWOZWWRDOXPKKDREB4DUIARDLANCNFSM5FUQPWXA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
jemorrison
added a commit
to jemorrison/jwst
that referenced
this pull request
Oct 21, 2021
jemorrison
added a commit
to jemorrison/jwst
that referenced
this pull request
Oct 21, 2021
nden
pushed a commit
to nden/jwst
that referenced
this pull request
Nov 2, 2021
* First Documentation for step * update doc * updates for fringefreq reference file * update of all docs * Update after review * various updates * fixed format of table
nden
pushed a commit
to nden/jwst
that referenced
this pull request
Nov 2, 2021
…ubes (spacetelescope#6405) * added reg test for internal_cal * Change names of tests * Updated change log for a missing entry for spacetelescope#6387
nden
pushed a commit
to nden/jwst
that referenced
this pull request
Nov 2, 2021
* First Documentation for step * update doc * updates for fringefreq reference file * update of all docs * Update after review * various updates * fixed format of table
nden
pushed a commit
to nden/jwst
that referenced
this pull request
Nov 2, 2021
…ubes (spacetelescope#6405) * added reg test for internal_cal * Change names of tests * Updated change log for a missing entry for spacetelescope#6387
loicalbert
pushed a commit
to talensgj/jwst
that referenced
this pull request
Nov 5, 2021
* First Documentation for step * update doc * updates for fringefreq reference file * update of all docs * Update after review * various updates * fixed format of table
loicalbert
pushed a commit
to talensgj/jwst
that referenced
this pull request
Nov 5, 2021
…ubes (spacetelescope#6405) * added reg test for internal_cal * Change names of tests * Updated change log for a missing entry for spacetelescope#6387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6370
Resolves JP-2294
Description
This PR is the documentation for the new step, residual_fringe step.
Checklist